Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update notification] - Is shown to non owners in the list of past notification #1267

Closed
francovenica opened this issue Nov 29, 2022 · 2 comments · Fixed by #1473
Closed
Assignees
Labels
bug Something isn't working

Comments

@francovenica
Copy link
Contributor

Bug description

Comming from a safe you own that requires updating, if you switch to another safe that you don't own the notification is triggered again and is listed in the past notifications (the bell in the top) for that safe you are currenlty in

Environment

Steps to reproduce

  1. Have two safes in the sidebar, one you own < 1.3.0 and another you don't own of any version
  2. Go to the safe < 1.3.0 you own
  3. See the notification popping up and check the bell in the top bar
  4. Clear the notifications
  5. Go to the other safe you don't own

Expected result

No notification should shown. No past notifications should be listed in the past notifications list

Obtained result

No notification is shown, but still you can see it in the past notification list

Screenshots

Here I'm in a safe that I own and is fully Updated
Change to a safe that requires updating
Then changes to a safe I don't own and is fully updated
The notification in the list still has the link of this safe I don't own
notifications

@francovenica francovenica added the bug Something isn't working label Nov 29, 2022
@katspaugh
Copy link
Member

I think it's OK that it's shown in the history, but it's definitely a bug that the link takes you to the current Safe settings, not the one the notification was triggered in.

@francovenica
Copy link
Contributor Author

That third notification is generated when I enter into that last safe that I don't own and doesn't need to be updated. So that notification should not be generated at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants