Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Automate New Chain Checks #661

Closed
nlordell opened this issue Jun 24, 2024 · 1 comment
Closed

Fully Automate New Chain Checks #661

nlordell opened this issue Jun 24, 2024 · 1 comment
Assignees

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jun 24, 2024

Currently, there is a manual step of running new chain checks (bash bin/github-review.sh) for new issues. This can be automated and run in CI to reduce the manual checks needed by the protocol team when merging new chains.

The expected outcome is a new GitHub action that runs on new chain PRs and checks that implements all the checks from the GitHub review script. In addition, some further automation is required:

  • We could fetch the version, chain id and rpc from the PR.
  • If there are changes in any other path other than src/assets, the script should show an error
  • We should ensure there are not more than a single chain ID being added in a PR
@nlordell nlordell changed the title Automate New Chain Checks Fully Automate New Chain Checks Jun 24, 2024
@remedcu
Copy link
Member

remedcu commented Jul 9, 2024

Fixed in #683

@remedcu remedcu closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants