Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-unused-variable in TSLint config #28

Open
saadq opened this issue Jul 17, 2018 · 0 comments
Open

Remove no-unused-variable in TSLint config #28

saadq opened this issue Jul 17, 2018 · 0 comments
Labels
good first issue Good for newcomers. tslint This issue is exclusive to the tslint side of things.

Comments

@saadq
Copy link
Owner

saadq commented Jul 17, 2018

TSLint version >= 2.9 seems to have deprecated no-unused-variable.

...the changes in 2.9 make it much more complex for this rule to work as intended, especially with respect to the ignorePattern option.

It looks like people should now just make sure that their tsconfig.json has the noUnusedLocals option enabled which covers most of what no-unused-variable did.

Changes would need to be made here.

@saadq saadq added the tslint This issue is exclusive to the tslint side of things. label Jul 17, 2018
@saadq saadq added the good first issue Good for newcomers. label Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers. tslint This issue is exclusive to the tslint side of things.
Projects
None yet
Development

No branches or pull requests

1 participant