Fix loading detection not working #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading detection as it was originally using querry_selector(.stop).is_enabled() didn't work on my machine, perhaps bing chat website was changed and that button doesnt have the enabled attribute. I tried to turn condition to is_visible(), but the button didnt have that attribute either. During debugging this I found that button appears on typing indicator "panel" (cib_typing_indicator), and it changes itself when typing response, adds cancelable attribute to its element. It is None when typing is not active (i.e before or after typing was completed) Seems to work more or less reliable on my machine. The time.sleep(7) in get_last_message() probably should be changed to some computed value as it may depend on CPU/Network speed, but it was a quick hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading detection as it was originally using querry_selector(.stop).is_enabled() didn't work on my machine, perhaps bing chat website was changed and that button doesnt have the enabled attribute. I tried to turn condition to is_visible(), but the button didnt have that attribute either. During debugging this I found that button appears on typing indicator "panel" (cib_typing_indicator), and it changes itself when typing response, adds cancelable attribute to its element. It is None when typing is not active (i.e before or after typing was completed) Seems to work more or less reliable on my machine. The time.sleep(7) in get_last_message() probably should be changed to some computed value as it may depend on CPU/Network speed, but it was a quick hack.