Skip to content

Commit

Permalink
chore(test): fix testing on linux (#468)
Browse files Browse the repository at this point in the history
Some systems require the CHROME_BIN env
variable to be set for karma to hook
into the chrome binary for testing.
I noticed this while setting up
karma-webpack on my linux desktop.

Fixes N/A
  • Loading branch information
codymikol committed Jan 29, 2021
1 parent 52ac365 commit 57b131e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"husky": "^0.14.3",
"istanbul": "^0.4.5",
"jest": "^23.5.0",
"karma": "^6.0.0",
"karma": "^6.0.3",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^2.2.0",
"karma-mocha": "^1.3.0",
Expand Down
3 changes: 3 additions & 0 deletions test/integration/scenarios/basic-setup/basic-setup.test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
/* eslint-disable prettier/prettier */

import karmaChromeLauncher from 'karma-chrome-launcher';
import karmaMocha from 'karma-mocha';
import karmaChai from 'karma-chai';

import ScenarioUtils from '../../utils/ScenarioUtils';

process.env.CHROME_BIN = require('puppeteer').executablePath();

const path = require('path');

const karmaWebpack = require('../../../../lib/index');
Expand Down

0 comments on commit 57b131e

Please sign in to comment.