Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add CONTRIBUTING.md file, containing a proposal for #132

Merged

Conversation

jmcconnell26
Copy link
Contributor

contributing to the project

@anderejd
Copy link
Contributor

Looks good to me, let's leave this open for a while to get some feedback.

@anderejd anderejd merged commit f123dd0 into geiger-rs:master Nov 3, 2020
@Shnatsel
Copy link

Shnatsel commented Nov 3, 2020

I'm not convinced that signing commits is a good idea, since it increases the entry barrier for contributions and does not accomplish much without a solid identity management layer on top of it. I suggest making it optional rather than required.

@tarcieri
Copy link
Collaborator

tarcieri commented Nov 3, 2020

It also provides dubious security value until git migrates away from SHA-1, which is cryptographically broken.

@anderejd
Copy link
Contributor

anderejd commented Nov 3, 2020

Thanks for the feedback!

I agree that the entry barrier should be low, I have added emphasis using bold styling for the following sentence: "Pull requests are very welcome, and the below are guidelines, not rules."

I'll remove the point about commit signing in the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants