Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider updating to wasi v0.13.1+wasi-0.2.0 #492

Open
LikeLakers2 opened this issue Jul 23, 2024 · 1 comment · May be fixed by #499
Open

Consider updating to wasi v0.13.1+wasi-0.2.0 #492

LikeLakers2 opened this issue Jul 23, 2024 · 1 comment · May be fixed by #499

Comments

@LikeLakers2
Copy link

Hi! I noticed that getrandom appears to be using wasi v0.11.0+wasi-snapshot-preview1. The latest version of wasi is wasi v0.13.1+wasi-0.2.0.

I would normally recommend updating getrandom to use wasi v0.13 (newer versions are almost always better). However, I took a quick look at wasi's repository, specifically their readme, and found that wasi itself recommends staying on v0.11 in certain circumstances.

Still, I'm hesitant to simply assume that the getrandom developers know of any of this - and in any case, I didn't see issues or PRs with information on why getrandom isn't using a newer version. So, I wanted to make this issue. If nothing else, it'll be an opportunity to explain why getrandom isn't using a newer version.

Thank you in advance.
@newpavlov
Copy link
Member

IIUC the wasm32-wasi target uses the preview1 API, so we should keep using wasi v0.11 on it and wasip1 targets. Meanwhile, wasi v0.13 should be used for wasip2 targets.

But I am not sure what value target_os has on wasm32-wasi, wasm32-wasip1, and wasm32-wasip2. Is it wasi, wasip1, and wasip2? Or wasi for all of them? If it's the latter, I think we have a problem...

@newpavlov newpavlov linked a pull request Sep 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@newpavlov @LikeLakers2