Make cargo bootimage use cargo build instead of cargo xbuild
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change since it changes the default build command to `cargo build`.
It should be no longer necessary.
phil-opp
force-pushed
the
build-with-cargo-build
branch
from
d9a04cd
to
2cb9a97
Compare
|
Published as v0.9.0 |
phil-opp
added a commit
that referenced
this pull request
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
cargo bootimagecommand to build the kernel using a normalcargo buildinstead ofcargo xbuildby default. This makes it possible to create kernels that don't depend on thecargo-xbuildcrate anymore.The cargo subcommand that is used for the kernel build can be adjusted by a new
package.metadata.bootimage.build-commandconfiguration key, which is set to["build"]. By setting it to["xbuild"], it is possible to make the kernel build use thecargo-xbuildcrate again. It is also possible to pass additional build arguments.This is a breaking change.