Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Move cfg(tests) modules to its own files #1029

Open
tesuji opened this issue Mar 1, 2021 · 1 comment
Open

cleanup: Move cfg(tests) modules to its own files #1029

tesuji opened this issue Mar 1, 2021 · 1 comment

Comments

@tesuji
Copy link
Contributor

tesuji commented Mar 1, 2021

The tests mod in stdarch is really big. We should split them into their own files instead of inline them into other mods.

This has been discussed for libstd in rust-lang/compiler-team#344.
Also see some other tricks in https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html.

@lqd
Copy link
Member

lqd commented Mar 3, 2021

Potentially interesting: having them in integration tests would mean we wouldn't have to update the test code when migrating away from #[rustc_args_required_const] as described in #1022. They'd be in another crate, and rustc would rewrite the calls via #[rustc_legacy_const_generics].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants