Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 3624 supertrait_item_shadowing (v2) #125782

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 30, 2024

Implements RFC 3624 and the associated lint in the RFC.

Tracking:

cc @Amanieu and rust-lang/rfcs#3624 and #89151

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2024
@compiler-errors compiler-errors changed the title Implement RFC 3624 supertrait_item_shadowing Implement RFC 3624 supertrait_item_shadowing (v2) May 30, 2024
@traviscross traviscross added the F-supertrait_item_shadowing `#![feature(supertrait_item_shadowing)]` label May 30, 2024
@bors
Copy link
Contributor

bors commented Jul 29, 2024

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2024
@compiler-errors compiler-errors force-pushed the supertrait-item-shadowing branch 2 times, most recently from e7d2da1 to e95db1b Compare September 19, 2024 01:37
@compiler-errors
Copy link
Member Author

OK, this is ready pending RFC approval.

@rust-log-analyzer

This comment has been minimized.

@compiler-errors compiler-errors marked this pull request as ready for review September 19, 2024 15:51
@compiler-errors
Copy link
Member Author

The RFC is now in FCP, so this could probably get reviewed preliminarily but should probably not land until the RFC is merged.

r? compiler

@bors
Copy link
Contributor

bors commented Sep 20, 2024

☔ The latest upstream changes (presumably #124895) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-supertrait_item_shadowing `#![feature(supertrait_item_shadowing)]` S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants