Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing AsMut<str> implementation for String #68741

Closed
tspiteri opened this issue Feb 1, 2020 · 2 comments · Fixed by #68742
Closed

missing AsMut<str> implementation for String #68741

tspiteri opened this issue Feb 1, 2020 · 2 comments · Fixed by #68742
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@tspiteri
Copy link
Contributor

tspiteri commented Feb 1, 2020

String has an inherent method as_mut_str, and implements both DerefMut and BorrowMut<str>. Is there a reason why it does not implement AsMut<str>, or was it just an oversight?
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 1, 2020
@tspiteri tspiteri mentioned this issue Feb 1, 2020
Merged
@ExpHP
Copy link
Contributor

ExpHP commented Feb 2, 2020

It just goes to show how useless &mut str is that nobody was bothered by this until today. 😛

@estebank
Copy link
Contributor

estebank commented Feb 3, 2020

Tangentially related: #44695

@bors bors closed this as completed in 3516df3 Feb 9, 2020
@nwtnni nwtnni mentioned this issue Mar 4, 2020
Closed
@jhg jhg mentioned this issue Apr 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement AsMut<str> for String tspiteri/rust
4 participants
@ExpHP @estebank @jonas-schievink @tspiteri