Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parallel-queries] Refactor layout-depth tracking so it does not need mutable state in the GlobalCtxt #49735

Closed
michaelwoerister opened this issue Apr 6, 2018 · 1 comment · Fixed by #100748
Closed

[parallel-queries] Refactor layout-depth tracking so it does not need mutable state in the GlobalCtxt #49735

michaelwoerister opened this issue Apr 6, 2018 · 1 comment · Fixed by #100748
Labels
A-parallel-queries Area: Parallel query execution C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

As described here, checking for too deep recursion when computing data layouts should not need to rely on mutable state in the GlobalCtxt.

@Zoxc has implemented one possible solution here: cb51381

Maybe there is an even simpler one that does not require explicitly entering a new tcx.

cc @eddyb & @nikomatsakis
@michaelwoerister michaelwoerister added the A-parallel-queries Area: Parallel query execution label Apr 6, 2018
@nikomatsakis nikomatsakis mentioned this issue Apr 6, 2018
Open
31 tasks
@nikomatsakis
Copy link
Contributor

I would think we could just walk the stack and check how many "layout" queries are on it -- maybe without anything in between

@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2018
@SparrowLii SparrowLii mentioned this issue Aug 19, 2022
Merged
@bors bors closed this as completed in cfb5ae2 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parallel-queries Area: Parallel query execution C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add depth_limit in QueryVTable to avoid entering a new tcx in layout_of SparrowLii/rust
3 participants
@nikomatsakis @michaelwoerister @XAMPPRocky