Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint on a call to exit in tests #966

Open
oli-obk opened this issue May 30, 2016 · 6 comments
Open

lint on a call to exit in tests #966

oli-obk opened this issue May 30, 2016 · 6 comments
Labels
A-lint Area: New lints L-tests Lint: Lints test code S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 30, 2016

cc rust-lang/rust#33954

Should be easy-enough once @llogiq's cross crate analyzer is up and running.

@mcarton mcarton added the A-lint Area: New lints label May 30, 2016
@llogiq
Copy link
Contributor

llogiq commented Jun 4, 2016

@Manishearth We should have a T-Test-related label.

@Manishearth
Copy link
Member

Well, T- is for categorizing how the lint is to be written, and is basically used to make the E- labels more finer grained.

But +1 for A-Test and A-style and whatnot. Or some other prefix (servo uses A-)

@llogiq
Copy link
Contributor

llogiq commented Jun 4, 2016

Fine with me.

@Manishearth Manishearth added the L-tests Lint: Lints test code label Jun 4, 2016
@felix91gr
Copy link
Contributor

Is this still a potential lint? I'd like to give it a try! :)

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 10, 2019

While still a potential lint, Without cross crate analysis capabilities or MIR-only-rlibs, any implementation we could do is pretty restricted

@felix91gr
Copy link
Contributor

Hmm. I see. Are those things coming? If not, maybe this can be tagged or otherwise noted somewhere as "good idea but necessary tooling isn't coming up anytime soon"?

@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: New lints L-tests Lint: Lints test code S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Development

No branches or pull requests

6 participants