Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for upcoming param_attrs feature #4474

Open
phansch opened this issue Aug 30, 2019 · 0 comments
Open

Support for upcoming param_attrs feature #4474

phansch opened this issue Aug 30, 2019 · 0 comments
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages E-needs-test Call for participation: writing tests good-first-issue These issues are a good way to get started with Clippy S-needs-discussion Status: Needs further discussion before merging or work can be started

Comments

@phansch
Copy link
Member

phansch commented Aug 30, 2019

param_attrs is likely to be stabilized in Rust 1.39

The param_attrs feature is going to allow lint attributes on function, method and closure parameters:

fn foo(
    a: i32,
    #[allow(unused_variables)] b: i32,
) {}

We should review how this feature ties in with our existing lints. Apparently it did not cause any toolstate breakage when it was merged.

Specifically, we should create a list of lints that could benefit from parameter attributes and then update those lints to make use of them (if that's even required).

@phansch phansch added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages S-needs-discussion Status: Needs further discussion before merging or work can be started E-needs-test Call for participation: writing tests good-first-issue These issues are a good way to get started with Clippy labels Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages E-needs-test Call for participation: writing tests good-first-issue These issues are a good way to get started with Clippy S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Development

No branches or pull requests

3 participants