Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonminimal_bool lint for meta items #1893

Open
clarfonthey opened this issue Jul 18, 2017 · 1 comment
Open

nonminimal_bool lint for meta items #1893

clarfonthey opened this issue Jul 18, 2017 · 1 comment

Comments

@clarfonthey
Copy link
Contributor

I found myself ctrl-replacing a bunch of meta items in a file and ended up with a few that said cfg(not(not(...))). This is obviously wrong and it would be nice if we linted this somehow.

We could potentially extend this from just double negatives to include other expressions which include too many nots, like any(not(A), not(B), not(C), ...) -> not(all(A, B, C)).

@oli-obk
Copy link
Contributor

oli-obk commented Jul 19, 2017

I'm not sure if we can do this. Items that are cfg'ed out are invisible to clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants