Lint !any(==) and similar

[mcarton]

At work I have a VS plugin suggesting to change stuff like !foo.any(|bar| bar == baz) to foo.all(|bar| bar != baz). !any and !all can usually be simplified.
It would be nice if nonminimal_bool could suggest that too.

[oli-obk]

actually !foo.any(|bar| bar == baz) requires fewer iterations than foo.all(|bar| bar != baz), so there's no trivial solution.

[oli-obk]

hmm.. ok wait... my brain was afk apparently... ignore my previous statement

[killercup]

Huh I think my brain is wired the same way as @oli-obk's because I too through any would short-circuit where all couldn't. Which is false because (spoiler alert) all short-circuits the first time the condition doesn't hold. (E.g., vec![1, 2, 3].iter().any(|&x| x == 2) stops and returns true after it sees the second item, and vec![1, 2, 3].iter().all(|&x| x == 2) stops and returns false on the second item.)

Just though I'd write that down for other people who might be wondering :)

[mcarton]

any is basically ||, all is basically &&. We already suggest simplifications on || and && so this should be considered too.

[camsteffen]

Personally I find !foo.any(|bar| bar == baz) to be cognitively simpler. My general rule is to defer "not" operators.