From f1955501481f4204a7189b13acc796a6583febde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Fri, 26 Jul 2019 22:58:31 +0200 Subject: [PATCH 1/2] rustup https://github.com/rust-lang/rust/pull/62964 --- clippy_lints/src/needless_pass_by_value.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs index 5098fa2a7365..c5283a432bcb 100644 --- a/clippy_lints/src/needless_pass_by_value.rs +++ b/clippy_lints/src/needless_pass_by_value.rs @@ -193,7 +193,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue { if_chain! { if !is_self(arg); - if !ty.is_mutable_pointer(); + if !ty.is_mutable_ptr(); if !is_copy(cx, ty); if !whitelisted_traits.iter().any(|&t| implements_trait(cx, ty, t, &[])); if !implements_borrow_trait; From 65fbea4b83143992349b94080effaa915bd6a039 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Fri, 26 Jul 2019 23:33:02 +0200 Subject: [PATCH 2/2] ci: temporarily disable rustfmt checks/tetss since it's broken for nightly --- .travis.yml | 2 +- appveyor.yml | 2 +- tests/fmt.rs | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0a1bd0ea2750..a2c5f002b84f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,7 +22,7 @@ env: install: - | if [ -z ${INTEGRATION} ]; then - rustup component add rustfmt || cargo install --git https://github.com/rust-lang/rustfmt/ --force +# rustup component add rustfmt || cargo install --git https://github.com/rust-lang/rustfmt/ --force if [ "$TRAVIS_OS_NAME" == "linux" ]; then . $HOME/.nvm/nvm.sh nvm install stable diff --git a/appveyor.yml b/appveyor.yml index 9f6cc45af81e..4cea8d99ec6d 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -22,7 +22,7 @@ install: - del rust-toolchain - cargo install rustup-toolchain-install-master --debug || echo "rustup-toolchain-install-master already installed" - rustup-toolchain-install-master %RUSTC_HASH% -f -n master - - rustup component add rustfmt --toolchain nightly + #- rustup component add rustfmt --toolchain nightly - rustup default master - set PATH=%PATH%;C:\Users\appveyor\.rustup\toolchains\master\bin - rustc -V diff --git a/tests/fmt.rs b/tests/fmt.rs index 2500132d7ad3..4df93cf5a085 100644 --- a/tests/fmt.rs +++ b/tests/fmt.rs @@ -1,4 +1,5 @@ #[test] +#[ignore] fn fmt() { if option_env!("RUSTC_TEST_SUITE").is_some() { return;