Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptr::NonNull is stable #214

Closed
SNCPlay42 opened this issue Apr 30, 2020 · 3 comments
Closed

ptr::NonNull is stable #214

SNCPlay42 opened this issue Apr 30, 2020 · 3 comments

Comments

@SNCPlay42
Copy link

SNCPlay42 commented Apr 30, 2020 •
edited
Loading

In src/vec-layout.md:

Unfortunately the mechanism for stating that your value is non-zero is unstable and unlikely to be stabilized soon. As such we're just going to take the hit and use std's Unique:

std::ptr::NonNull is stable since 1.25, while std::ptr::Unique is still feature-gated and even hidden from documentation. This should be updated to avoid unnecessarily using unstable features.
@SNCPlay42
Copy link
Author

Confusingly enough the final code chapter uses NonNull. Looks like it's out of sync with the other chapters?

@SNCPlay42
Copy link
Author

This was discussed in the comments of #161 but is not currently fixed in that PR. It seems likely that any PR fixing this will have merge conflicts with that one.

@SNCPlay42
Copy link
Author

Dupes #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SNCPlay42