Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Rumprun #2091

Closed
JohnTitor opened this issue Mar 1, 2021 · 3 comments · Fixed by #2828
Closed

Drop support for Rumprun #2091

JohnTitor opened this issue Mar 1, 2021 · 3 comments · Fixed by #2828
Assignees

Comments

@JohnTitor
Copy link
Member

rustc dropped the support for Rumprun in rust-lang/rust#82594. We could drop the support on libc as we did for CloudABI.
cc #2090

@joshtriplett
Copy link
Member

👍 to removing this support, since Rust did.

We may want to establish a policy here. Under what circumstances can we remove support for a target? Can we always do so when Rust does, or do we have any special considerations to take into account if the target was previously tier 1/2 and available in stable? Can we count on projects to have older versions of libc in their lockfiles if they need to run on older targets?

I think the answer is that we can remove targets when Rust does, but this seems worth confirming and documenting.

@JohnTitor
Copy link
Member Author

JohnTitor commented Mar 23, 2021

Note: I'm holding this (dropping support Rumprun) off due to circumstances.

Agree, I also think we can drop support for Tier 3 once rustc does. And for tier 1/2, I'm not 100% sure but does rustc suddenly drop their support without downgrading generally? If rustc does it, I would think there was a reasonable reason (and we should consider if libc also should drop the support, it will highly depend on the situation, I imagine). I'm happy to document this as a "target support policy" or something else if needed.
@rust-lang/libc Feel free to comment here if you have different opinions.

@workingjubilee
Copy link
Member

Agree, I also think we can drop support for Tier 3 once rustc does. And for tier 1/2, I'm not 100% sure but does rustc suddenly drop their support without downgrading generally?

Historically, Rust targets have dropped from as high as tier 1 to tier 3 as a single change, e.g. https://github.com/rust-lang/rfcs/pull/2837/files but have not been abruptly removed from tier 1 or tier 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants