Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illumos Tier3 targets #644

Closed
1 of 3 tasks
Toasterson opened this issue Jun 26, 2023 · 5 comments
Closed
1 of 3 tasks

Add illumos Tier3 targets #644

Toasterson opened this issue Jun 26, 2023 · 5 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Toasterson
Copy link

Toasterson commented Jun 26, 2023

Proposal

In the illumos community we have several CPU Architectures which are not in our main supported Builds, but they might become supported or endoresed depening on the developments in the Chip market, as can be seen by the popularity of ARM Chips. Even if our platform support will be limited to specific devices (RPI4/Quemu/bHyve) there are use cases that benefit from native binaries being available even now. Considering how many developers now have access to that architecture some use cases for ARM binaries and ARM rust builds are already present.

At this point in time we are only interested in Tier 3 so that we don't have to carry patches in the compiler for when we want to build toolchains or cross toolchains for us and can distribute upstream rust compiler packages for those architectures.

These targets will have some limitations, as one will need a proper GCC and linker installed on the system. Our linker is part of the illumos-gate repository and open source. As I understnad the Tier policy this is ok for Tier 3.

The Architectures that currently are in this experimental stage is aarch64.

We are only interested in having the definitions placed in the code and not additonal requirements for these three architectures.

The currently open PR is rust-lang/rust#112936

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@Toasterson Toasterson added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jun 26, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 26, 2023
@workingjubilee
Copy link
Member

@Toasterson Are you available on Zulip to discuss this?

Are you aware of the Target Tier Policy?

Are you agreeing to be the target maintainer for all of these?

Are you sure you wish to agree to be the only official SPARC64 maintainer since the institution of the target tier policy that guaranteed that targets require a known maintainer associated with them?

@Toasterson
Copy link
Author

I am unable to add to the discussion on Zulip as the "Stream" there is closed to me. Although I only just signed up so it might be that you need to enable my account.

In general unless otherwise stated all illumos targets are usually to be assumed to be maintained by the illumos developers. But if you need details I can arrange that we get it sorted.

I am unaware nor able to find any other inforamtion to SParc64 support other than the Target tier policy which shows several Operating systems in Tier 3 and two in Tier 2. The target sparcv9-sun-solaris even mentions illumos support and is Tier 2.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 29, 2023
@davidtwco
Copy link
Member

@rustbot second

This seems reasonable and we should have probably seconded it sooner, discussion in Zulip looks resolved :)

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Sep 20, 2023
@apiraino
Copy link
Contributor

apiraino commented Oct 2, 2023

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Oct 2, 2023
@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 2, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

5 participants