Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Workspace support may need some love after cargo#4788 #54

Closed
imp opened this issue Feb 15, 2018 · 6 comments
Closed

Workspace support may need some love after cargo#4788 #54

imp opened this issue Feb 15, 2018 · 6 comments

Comments

@imp
Copy link

imp commented Feb 15, 2018

Looks like rust-lang/cargo#4788 changed the way workspace crates are handled. Should atom-ide-rust take any action?

@alexheretic
Copy link
Member

alexheretic commented Feb 15, 2018

I don't believe so. Rls uses cargo commit from around the end of January, so should include that pr. Ide-rust itself simply starts Rls in the cwd of the project and lets Rls do the rest.

Everything seems to work as I'd expect. Workspaces build, you can open a part of a workspace as a project and it should also work.

Have you experienced some issues?

@imp
Copy link
Author

imp commented Feb 15, 2018

Yes, actually. Not sure how to describe it and not sure atom-ide-rust is to blame.
Every time I am following compilation errors from the editor - whole workspace member file tree is recreated at the point the offending file is found. Kinda weird. Like I said - I can not point at anything specific to atom-ide-rust, just came across this issue and saw that others editor plugins made some adaptation.

futures-rs repo if you willing to have a look yourself

@alexheretic
Copy link
Member

I don't notice any funny business creating and navigating to compile errors on futures-rs myself.

Can you try to debug?

  • Ensure atom is 1.23.3 or later
  • Disable all atom community packages except ide-rust, atom-ide-ui, language-rust
  • Remove all project folders except futures-rs
  • Ensure latest nightly is installed and nightly is selected as ide-rust toolchain
  • Restart atom
  • Reproduce issue

If it still occurs, please let me know the steps to re-create & I'll try to investigate again.

@alexheretic
Copy link
Member

@imp did you get to the bottom of this issue. Is it still occurring?

@imp
Copy link
Author

imp commented Mar 3, 2018

I am not able to reproduce this issue with all the components updated as of 2018-03-03. Looks like one of the latest updates fixed it or otherwise made it go away.

@imp imp closed this as completed Mar 3, 2018
@alexheretic
Copy link
Member

Thanks for the update, let's hope it doesn't come back!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants