Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect MSVC 2017. Closes #1003 #1136

Merged
merged 1 commit into from
May 27, 2017
Merged

Detect MSVC 2017. Closes #1003 #1136

merged 1 commit into from
May 27, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented May 25, 2017

Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.

@Diggsey
Copy link
Contributor

Diggsey commented May 25, 2017

@brson Error looks legit!

@brson
Copy link
Contributor Author

brson commented May 26, 2017

OK, I think I see the issue.

@brson
Copy link
Contributor Author

brson commented May 26, 2017

Testing using a temporary branch of gcc-rs

@brson
Copy link
Contributor Author

brson commented May 26, 2017

Oh yay!

@brson
Copy link
Contributor Author

brson commented May 26, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 26, 2017

📌 Commit 99cbfe0 has been approved by brson

@bors
Copy link
Contributor

bors commented May 26, 2017

⌛ Testing commit 99cbfe0 with merge 6dead9a...

bors added a commit that referenced this pull request May 26, 2017
Detect MSVC 2017. Closes #1003

Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
@brson
Copy link
Contributor Author

brson commented May 26, 2017

still just testing

@brson
Copy link
Contributor Author

brson commented May 26, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 26, 2017

📌 Commit 99cbfe0 has been approved by brson

@bors
Copy link
Contributor

bors commented May 26, 2017

⌛ Testing commit 99cbfe0 with merge 089e2c4...

bors added a commit that referenced this pull request May 26, 2017
Detect MSVC 2017. Closes #1003

Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
@bors
Copy link
Contributor

bors commented May 26, 2017

💔 Test failed - status-appveyor

@brson
Copy link
Contributor Author

brson commented May 26, 2017

@bors retry

Spurious. Suspicious.

@bors
Copy link
Contributor

bors commented May 26, 2017

⌛ Testing commit 99cbfe0 with merge c60e5e4...

bors added a commit that referenced this pull request May 26, 2017
Detect MSVC 2017. Closes #1003

Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
@bors
Copy link
Contributor

bors commented May 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing c60e5e4 to master...

@bors bors merged commit 99cbfe0 into rust-lang:master May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants