feat: update infrastructure to use macOS 14 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting lots of registry failures on the e2e tests - though it seems the last few commits have been failing the e2e tests. |
weikequ
force-pushed
the
update-to-sonoma
branch
from
a39186f
to
05c86f3
Compare
|
Can you merge in main to see if the latest commit fixes the e2e tests? |
Requeued the e2e tests and now it is running |
weikequ
force-pushed
the
update-to-sonoma
branch
from
05c86f3
to
5564bdb
Compare
|
Still e2e test failures, but a different test this time. The same failure is experience in previous commits to main as well. Finch Core E2E Tests Build container image Build container image using default image Build an image with --ssh option
/Users/ec2-user/go/pkg/mod/github.com/runfinch/common-tests@v0.7.9/tests/build.go:129
No containers to be removed
No images to be removed
No volumes to be removed
host
none
No networks to be removed
error: invalid empty ssh agent socket: make sure SSH_AUTH_SOCK is set
[FAILED] in [It] - /Users/ec2-user/go/pkg/mod/github.com/runfinch/common-tests@v0.7.9/command/command.go:122 @ 12/06/23 17:55:39.229
No containers to be removed
No images to be removed
No volumes to be removed
host
none
No networks to be removed
• [FAILED] [0.698 seconds]
Finch Core E2E Tests Build container image Build container image using default image [It] Build an image with --ssh option |
KevinLiAWS
approved these changes
Dec 7, 2023
Signed-off-by: Weike Qu <weikequ@amazon.com>
weikequ
force-pushed
the
update-to-sonoma
branch
from
5564bdb
to
42ee7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, will hold off on merging until infrastructure is available.
Issue #, if available:
Description of changes:
Updated references toVenturain our workflow to refer to thelatestmacOS version insteadTesting done:
none
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.