Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e tests #143

Merged
merged 8 commits into from
Aug 25, 2023
Merged

fix: e2e tests #143

merged 8 commits into from
Aug 25, 2023

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Aug 24, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324
fix: e2e tests
47d38ce 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
update ci workflow
7b72667 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix path
5231010 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
update make target
1a379aa 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
install dependencies
03dbdc9 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
install lima.dependencies
a9c76dd 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
update common-tests
73fdbc9 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
fix dependency caching
134891e 
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Copy link
Member Author

Prior run succeeded. Waiting for new tests to pass.

@pendo324 pendo324 requested a review from vsiravar August 24, 2023 22:51
@pendo324 pendo324 marked this pull request as ready for review August 24, 2023 22:51
vsiravar
vsiravar approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@vsiravar vsiravar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@pendo324 pendo324 merged commit 0ab8035 into runfinch:main Aug 25, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvazquez austinvazquez austinvazquez approved these changes

@vsiravar vsiravar vsiravar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pendo324 @austinvazquez @vsiravar