Update examine-log #6623
Open
Update examine-log #6623
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have not checked your code, but keep in mind:
|
format code and only load logs on new log in
|
@YvesW thanks for the callout have updated it to only load logs from log in if they haven't loaded. Additionally on world hop or login screen states it clears the loaded account (hopping to temp world etc). |
clear logs to avoid sharing progress across temp worlds
fix for fixed classic layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from player name to rsprofile and added failsafe loading before writing.
Uses
onGameStateChanged->state == GameState.LOGGED_INthen usesconfigManager.getRSProfileKey()and stores data inside that folder.Also fixes for fixed classic mode not showing popups.