Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add all apple family support #925

Merged
merged 5 commits into from
Dec 30, 2021
Merged

feat: add all apple family support #925

merged 5 commits into from
Dec 30, 2021

Conversation

akashrpo
Copy link
Contributor

Description of the change

add support for all apple family devices

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akashrpo akashrpo added enhancement New feature or request WIP labels Dec 29, 2021
@akashrpo akashrpo self-assigned this Dec 29, 2021
saikumarrs
saikumarrs reviewed Dec 29, 2021
View reviewed changes
v0/util/index.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs requested changes Dec 29, 2021
View reviewed changes
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases for all the destinations and souces

@saikumarrs saikumarrs merged commit 0962527 into master Dec 30, 2021
@akashrpo akashrpo deleted the add-apple-supported-plat branch December 30, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

Assignees

@akashrpo akashrpo

Labels
enhancement New feature or request Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashrpo @desusai7 @saikumarrs