Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect usage of histogram as counter #2335

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

koladilip
Copy link
Contributor

Description of the change

hv_request_size is histogram but used as couter.
Fixes this error: Counter metric hv_request_size failed with error TypeError: metric.inc is not a function. Value: 2223

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@koladilip koladilip requested review from a team and sivashanmukh as code owners July 5, 2023 04:57
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (72fb4a2) 87.15% compared to head (71c8c3a) 87.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2335   +/-   ##
========================================
  Coverage    87.15%   87.15%           
========================================
  Files          490      490           
  Lines        25442    25442           
  Branches      6301     6301           
========================================
  Hits         22174    22174           
  Misses        2900     2900           
  Partials       368      368           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@koladilip koladilip merged commit 654f0ad into develop Jul 5, 2023
10 checks passed
@koladilip koladilip deleted the fix.incorrect-usage-of-histogram-metric branch July 5, 2023 06:46
@koladilip koladilip restored the fix.incorrect-usage-of-histogram-metric branch July 5, 2023 06:47
@devops-github-rudderstack devops-github-rudderstack deleted the fix.incorrect-usage-of-histogram-metric branch October 6, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants