fix: error extraction migrated to typescript #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated the jest configuration to support typescript in javascript - updated couple of test-files to move from implicit declaration to explicit declaration
sanpj2292
requested review from
aashishmalik and
sandeepdsvs
and removed request for
a team
10 tasks
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat.error-enrich-fb-pixel #2233 +/- ##
==============================================================
+ Coverage 88.57% 88.58% +0.01%
==============================================================
Files 511 510 -1
Lines 25876 25867 -9
Branches 6380 6380
==============================================================
- Hits 22919 22915 -4
+ Misses 2642 2637 -5
Partials 315 315
☔ View full report in Codecov by Sentry. |
sanpj2292
requested review from
krishna2020,
utsabc,
yashasvibajpai and
koladilip
krishna2020
approved these changes
Jun 2, 2023
yashasvibajpai
approved these changes
Jun 2, 2023
sanpj2292
added a commit
that referenced
this pull request
Jun 5, 2023
…#2018) * feat: error enrichment to get clear error messages for facebook pixel * feat: update 500 status-code for error_subcode 99 * fix: update test-cases with relevant error messages * feat: add more status-codes to the error detail extraction way, add test-cases for them as well * fix: FB destination responses since it is using fb_pixel network handler Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: error message trimmed * fix: fb proxy unit-tests * fix: remove TODOs * fix: builder refactor Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: clean-up status-code logic by defaulting to 500 when status-code not available Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: remove unnecessary comments Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: sonar lint for empty class with a constructor Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: error extraction migrated to typescript (#2233) - updated the jest configuration to support typescript in javascript - updated couple of test-files to move from implicit declaration to explicit declaration Co-authored-by: Sai Sankeerth <sanpj2292@github.com> --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
made use of the typescript error extraction class
updated logic to throw unhandled status code error(in a different way without using
UnHandledStatusCodeErrorclass)added test-cases for the unhandled status code case
updated the jest configuration to support typescript in javascript
updated couple of test-files to move from implicit declaration to explicit declaration
Type of change
Related issues
Checklists
Development
Code review