Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stats for bad events in fb_custom_audience #2192

Merged
merged 14 commits into from
Jun 1, 2023
Merged

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

Add stats for bad events in fb_custom_audience

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab self-assigned this May 22, 2023
@ujjwal-ab ujjwal-ab requested a review from a team as a code owner May 22, 2023 02:25
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (075f819) 88.55% compared to head (c18bcd9) 88.56%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2192   +/-   ##
========================================
  Coverage    88.55%   88.56%           
========================================
  Files          509      509           
  Lines        25835    25848   +13     
  Branches      6376     6377    +1     
========================================
+ Hits         22879    22892   +13     
  Misses        2641     2641           
  Partials       315      315           
Impacted Files Coverage Δ
src/util/prometheus.js 7.07% <0.00%> (ø)
...rc/v0/destinations/fb_custom_audience/transform.js 94.23% <ø> (ø)
src/v0/destinations/fb_custom_audience/util.js 93.27% <100.00%> (+0.82%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauravudia
Copy link
Contributor

@ujjwal-ab You need to add the stats in the prometheus.js file as well.

@ujjwal-ab ujjwal-ab requested review from a team, sivashanmukh and lvrach as code owners May 25, 2023 11:54
@koladilip
Copy link
Contributor

we don't have label names are consistent

koladilip
koladilip previously approved these changes May 25, 2023
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

destinationId destination_id destination we are using different labels, something we need to standardise

sanpj2292
sanpj2292 previously approved these changes May 25, 2023
@ujjwal-ab ujjwal-ab dismissed stale reviews from sanpj2292 and koladilip via f047c30 May 29, 2023 07:13
sanpj2292
sanpj2292 previously approved these changes May 30, 2023
@sanpj2292 sanpj2292 requested a review from koladilip May 30, 2023 04:42
koladilip
koladilip previously approved these changes Jun 1, 2023
@koladilip koladilip dismissed their stale review June 1, 2023 06:22

mistakenly approved

koladilip
koladilip previously approved these changes Jun 1, 2023
src/v0/destinations/fb_custom_audience/util.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@ujjwal-ab ujjwal-ab merged commit 8176874 into develop Jun 1, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the feat.add-stats branch September 2, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants