-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats for bad events in fb_custom_audience #2192
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2192 +/- ##
========================================
Coverage 88.55% 88.56%
========================================
Files 509 509
Lines 25835 25848 +13
Branches 6376 6377 +1
========================================
+ Hits 22879 22892 +13
Misses 2641 2641
Partials 315 315
☔ View full report in Codecov by Sentry. |
@ujjwal-ab You need to add the stats in the |
we don't have label names are consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
destinationId destination_id destination we are using different labels, something we need to standardise
Kudos, SonarCloud Quality Gate passed! |
Description of the change
Add stats for bad events in fb_custom_audience
Type of change
Related issues
Checklists
Development
Code review