Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixpanel): add support of simplified api #2042

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Apr 5, 2023

Description of the change

Add support for Simplified ID merge API

  • Drop $merge event support when Simplified ID merge is selected
  • Remove support of alias call when Simplified ID merge is selected
  • Add $device_id and $user_id when Simplified ID merge is selected

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia added the enhancement New feature or request label Apr 5, 2023
@Gauravudia Gauravudia requested a review from ItsSudip April 5, 2023 12:33
@Gauravudia Gauravudia self-assigned this Apr 5, 2023
@Gauravudia Gauravudia requested a review from a team as a code owner April 5, 2023 12:33
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3e5d82) 87.48% compared to head (87a03fe) 87.49%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2042   +/-   ##
========================================
  Coverage    87.48%   87.49%           
========================================
  Files          501      501           
  Lines        25226    25237   +11     
  Branches      6322     6331    +9     
========================================
+ Hits         22069    22080   +11     
  Misses        2819     2819           
  Partials       338      338           
Impacted Files Coverage Δ
src/v0/destinations/mp/transform.js 98.37% <100.00%> (+0.08%) ⬆️
src/v0/destinations/mp/util.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants