Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapchat_conversion): price calculation #1988

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Mar 23, 2023

Description of the change

Fix price calculation.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia added the bug Something isn't working label Mar 23, 2023
@Gauravudia Gauravudia requested a review from a team as a code owner March 23, 2023 10:14
@Gauravudia Gauravudia self-assigned this Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (098f2b1) 87.31% compared to head (2ca36d4) 87.31%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1988   +/-   ##
========================================
  Coverage    87.31%   87.31%           
========================================
  Files          457      457           
  Lines        24921    24922    +1     
  Branches      6247     6251    +4     
========================================
+ Hits         21760    21761    +1     
  Misses        2824     2824           
  Partials       337      337           
Impacted Files Coverage Δ
...c/v0/destinations/snapchat_conversion/transform.js 92.68% <100.00%> (ø)
src/v0/destinations/snapchat_conversion/util.js 81.17% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

krishna2020
krishna2020 previously approved these changes Mar 23, 2023
@Gauravudia Gauravudia merged commit 8240224 into develop Mar 27, 2023
@Gauravudia Gauravudia deleted the fix/snapchatConversion-price-calculation branch March 27, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants