Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration): pinterest content_id field dropped when having null value to match with cdkv2 #1950

Merged
merged 3 commits into from
Mar 20, 2023
Merged

fix(integration): pinterest content_id field dropped when having null value to match with cdkv2 #1950

merged 3 commits into from
Mar 20, 2023

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Mar 15, 2023 •
edited
Loading

ref

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shrouti1507 shrouti1507 requested a review from a team as a code owner March 15, 2023 12:03
@shrouti1507 shrouti1507 changed the title fix(integration): Pinterest content_id field dropped when having null value to match with CDKv2 fix(integration): pinterest content_id field dropped when having null value to match with CDKv2 Mar 15, 2023
@shrouti1507 shrouti1507 changed the title fix(integration): pinterest content_id field dropped when having null value to match with CDKv2 fix(integration): pinterest content_id field dropped when having null value to match with cdkv2 Mar 15, 2023
@shrouti1507 shrouti1507 merged commit 09995e9 into develop Mar 20, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the fix/pinterest-match-with-cdkv2 branch June 16, 2023 01:30
@shrouti1507 shrouti1507 mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrouti1507 @koladilip @ItsSudip