Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mautic: support self hosted instance #1909

Merged
merged 12 commits into from
Mar 10, 2023
Merged

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Mar 2, 2023

Description of the change

We will be supporting self hosted instance of mautic through this and for the same reason username could be anything and not particularly email address so removed that as well.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 changed the title Enhancement.mautic feat: mautic: support self hosted instance Mar 2, 2023
src/v0/destinations/mautic/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/mautic/transform.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/v0/destinations/mautic/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/mautic/transform.js Outdated Show resolved Hide resolved
Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the package-lock.json changes.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
88% (+0% 🔼)
19629/22306
🟡 Branches
74.23% (+0.01% 🔼)
8360/11263
🟢 Functions
90.76% (+0% 🔼)
2211/2436
🟢 Lines
88.1% (+0% 🔼)
19465/22093
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / transform.js
97.67% (-0.05% 🔻)
88.1% (-0.54% 🔻)
100%
97.67% (-0.05% 🔻)

Test suite run success

2605 tests passing in 179 suites.

Report generated by 🧪jest coverage report action from 37ab44f

@anantjain45823 anantjain45823 changed the base branch from main to develop March 7, 2023 08:45
@anantjain45823 anantjain45823 merged commit 7c0a724 into develop Mar 10, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the enhancement.mautic branch June 11, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants