Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding tiktok ads to transformmer proxy #1905

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

yashasvibajpai
Copy link
Contributor

Description of the change

Onboarding tiktok ads to transformer proxy

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this Mar 1, 2023
@yashasvibajpai yashasvibajpai changed the base branch from main to develop March 7, 2023 09:11
@github-actions
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (593bcc0) 87.49% compared to head (fadd926) 87.50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1905   +/-   ##
========================================
  Coverage    87.49%   87.50%           
========================================
  Files          501      502    +1     
  Lines        25239    25256   +17     
  Branches      6332     6333    +1     
========================================
+ Hits         22083    22100   +17     
  Misses        2818     2818           
  Partials       338      338           
Impacted Files Coverage Δ
src/v0/destinations/tiktok_ads/config.js 100.00% <ø> (ø)
src/v0/destinations/tiktok_ads/networkHandler.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yashasvibajpai yashasvibajpai marked this pull request as ready for review April 14, 2023 09:13
@yashasvibajpai yashasvibajpai requested a review from a team as a code owner April 14, 2023 09:13
@yashasvibajpai yashasvibajpai merged commit d26a924 into develop Apr 14, 2023
@yashasvibajpai yashasvibajpai deleted the feat.onboard.tiktokads.proxy branch April 14, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants