Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fb to transformer proxy #1900

Merged
merged 6 commits into from
Mar 31, 2023
Merged

feat: add fb to transformer proxy #1900

merged 6 commits into from
Mar 31, 2023

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

add fb to transformer proxy

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab self-assigned this Feb 28, 2023
@ujjwal-ab ujjwal-ab changed the base branch from main to develop March 7, 2023 08:19
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (650030e) 87.05% compared to head (ea2b3c0) 87.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1900   +/-   ##
========================================
  Coverage    87.05%   87.06%           
========================================
  Files          459      460    +1     
  Lines        25098    25110   +12     
  Branches      6291     6291           
========================================
+ Hits         21850    21862   +12     
  Misses        2900     2900           
  Partials       348      348           
Impacted Files Coverage Δ
...c/v0/destinations/facebook_pixel/networkHandler.js 97.43% <ø> (ø)
src/v0/destinations/fb/networkHandler.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ujjwal-ab ujjwal-ab marked this pull request as ready for review March 15, 2023 04:56
@ujjwal-ab ujjwal-ab requested a review from a team as a code owner March 15, 2023 04:56
@ujjwal-ab ujjwal-ab merged commit 7e6341f into develop Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants