Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ga4 userId issue #1857

Merged
merged 2 commits into from
Feb 13, 2023
Merged

fix: ga4 userId issue #1857

merged 2 commits into from
Feb 13, 2023

Conversation

mihir-4116
Copy link
Contributor

Description of the change

  • event is failing to ga4 if user_id parameter is int
  • in this pr we are converting userId to string so that it will not fail

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 requested a review from a team as a code owner February 10, 2023 06:01
@mihir-4116 mihir-4116 self-assigned this Feb 10, 2023
@mihir-4116 mihir-4116 merged commit cd30c47 into master Feb 13, 2023
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the fix/ga4-userId branch May 11, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

Assignees

@mihir-4116 mihir-4116

Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihir-4116 @utsabc @ItsSudip