Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(destination): onboard lemnisk integration #1787

Merged
merged 13 commits into from
Jan 19, 2023
Merged

feat(destination): onboard lemnisk integration #1787

merged 13 commits into from
Jan 19, 2023

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Jan 16, 2023 •
edited
Loading

Description of the change

#1728 continued here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

praveendsviz and others added 3 commits January 11, 2023 16:31
@praveendsviz @anantjain45823
feat(destination): onboard lemnisk integration (#1728)
07750a4 
* Added all transformation logic and test cases

* Modified transforme.js and some tests for Lemnisk integration

Co-authored-by: Praveen DS <--unset>
Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com>
@anantrudder
feat: onboard lemnisk
d48f20d
@anantrudder
feat: added test cases
0e4c576
@anantjain45823 anantjain45823 requested a review from a team as a code owner January 16, 2023 06:54
@anantjain45823 anantjain45823 self-assigned this Jan 16, 2023
ItsSudip
ItsSudip reviewed Jan 17, 2023
View reviewed changes
src/v0/destinations/lemnisk/utils.js Outdated Show resolved Hide resolved
src/v0/destinations/lemnisk/utils.js Outdated Show resolved Hide resolved
src/v0/destinations/lemnisk/transform.js Show resolved Hide resolved
ItsSudip
ItsSudip previously approved these changes Jan 17, 2023
View reviewed changes
@anantjain45823 anantjain45823 merged commit 3c6b9e1 into master Jan 19, 2023
@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the feat.lemnisk branch April 20, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@Gauravudia Gauravudia Gauravudia approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@anantjain45823 anantjain45823

Labels
new-integration Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anantjain45823 @yashasvibajpai @Gauravudia @ItsSudip @praveendsviz @anantrudder