Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facebook pixel): error code mapping for transformer proxy #1738

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

Gauravudia
Copy link
Contributor

Description of the change

Error code 190 (invalid access token) was mapped to retryable error codes. Now, mapped it to abortable error codes. As, we are using router transform for this destination and access token is coming from webapp.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia requested a review from a team as a code owner December 28, 2022 12:48
@Gauravudia Gauravudia self-assigned this Dec 28, 2022
@Gauravudia Gauravudia merged commit 4e98299 into master Jan 5, 2023
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the fix.fbPixel-transformer-proxy branch April 6, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants