Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sendgrid idetify and user deletion support #1571

Merged
merged 8 commits into from
Nov 17, 2022
Merged

feat: sendgrid idetify and user deletion support #1571

merged 8 commits into from
Nov 17, 2022

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Nov 14, 2022 •
edited
Loading

Description of the change

  • This is a pr for sendgrid new features : identify call and userdeletion support
  • all sendgrid test cases converted to GA4 format
  • in indetify and userdeletion we are supporting batching and batching limit is 30000

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 requested review from a team and arnab-p as code owners November 14, 2022 15:30
@mihir-4116 mihir-4116 self-assigned this Nov 14, 2022
ItsSudip
ItsSudip requested changes Nov 16, 2022
View reviewed changes
v0/destinations/sendgrid/deleteUsers.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/transform.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Outdated Show resolved Hide resolved
v0/destinations/sendgrid/util.js Show resolved Hide resolved
@arnab-p arnab-p merged commit caee969 into master Nov 17, 2022
@arnab-p arnab-p deleted the feature/sd branch November 17, 2022 07:23
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnab-p arnab-p arnab-p approved these changes

@sauravlal15 sauravlal15 sauravlal15 approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees

@mihir-4116 mihir-4116

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihir-4116 @arnab-p @sauravlal15 @ItsSudip