Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(destination): skip unix timestamp conversion if already being se… #1560

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

yashasvibajpai
Copy link
Contributor

…nt from source

Description of the change

We have seen unnecessary truncation of timestamp values if the source was already sending a unix timestamp, and we are utilising the metadata function to convert it to a unix timestamp. Hence we are introducing a check to validate if the received property is already a timestamp so essentially should be skipped from the conversion flow.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai merged commit a52cbd7 into master Nov 10, 2022
@yashasvibajpai yashasvibajpai deleted the fix/unix-timestamp-skip branch November 10, 2022 08:46
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants