Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(error reporting): integrate bugsnag #1469

Merged
merged 24 commits into from
Oct 25, 2022
Merged

feat(error reporting): integrate bugsnag #1469

merged 24 commits into from
Oct 25, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Oct 10, 2022 •
edited
Loading

Description of the change

Integrated Bugsnag error collection tool to notify handled and unhandled errors.
Presently, only the versionedRouter.js module is instrumented.

Note: Only the destination transformations and data delivery endpoints are instrumented for now.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

koladilip
koladilip reviewed Oct 10, 2022
View reviewed changes
util/errorNotifier/bugsnag.js Outdated Show resolved Hide resolved
versionedRouter.js Show resolved Hide resolved
versionedRouter.js Show resolved Hide resolved
versionedRouter.js Show resolved Hide resolved
versionedRouter.js Outdated Show resolved Hide resolved
utsabc
utsabc reviewed Oct 10, 2022
View reviewed changes
versionedRouter.js Outdated Show resolved Hide resolved
versionedRouter.js Outdated Show resolved Hide resolved
saikumarrs and others added 2 commits October 10, 2022 23:25
@saikumarrs @koladilip
refactor: bugsnag notify api
6c09ec8 
Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com>
@saikumarrs
refactor: update context for batch transformation
402ad92
koladilip
koladilip previously approved these changes Oct 11, 2022
View reviewed changes
utsabc
utsabc previously approved these changes Oct 11, 2022
View reviewed changes
koladilip
koladilip previously approved these changes Oct 21, 2022
View reviewed changes
koladilip
koladilip reviewed Oct 21, 2022
View reviewed changes
versionedRouter.js Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Oct 21, 2022
View reviewed changes
@saikumarrs saikumarrs dismissed stale reviews from utsabc and koladilip via ffdc5de October 21, 2022 06:11
@saikumarrs saikumarrs self-assigned this Oct 22, 2022
@saikumarrs saikumarrs merged commit 39b5fa2 into master Oct 25, 2022
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
Merged
@github-actions github-actions bot deleted the feat.integrate-bugsnag branch March 15, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@koladilip koladilip koladilip approved these changes

@krishna2020 krishna2020 Awaiting requested review from krishna2020

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

Assignees

@saikumarrs saikumarrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saikumarrs @sanpj2292 @utsabc @koladilip