Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate cdk v2 #1448

Merged
merged 19 commits into from
Sep 30, 2022
Merged

feat: integrate cdk v2 #1448

merged 19 commits into from
Sep 30, 2022

Conversation

saikumarrs
Copy link
Member

Description of the change

Integrated CDK 2.0.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs added the WIP label Sep 28, 2022
koladilip
koladilip previously approved these changes Sep 29, 2022
View reviewed changes
@saikumarrs saikumarrs removed the WIP label Sep 29, 2022
@saikumarrs saikumarrs marked this pull request as ready for review September 29, 2022 13:07
koladilip
koladilip reviewed Sep 29, 2022
View reviewed changes
cdk/v2/utils.js Outdated Show resolved Hide resolved
sanpj2292
sanpj2292 reviewed Sep 30, 2022
View reviewed changes
versionedRouter.js Outdated Show resolved Hide resolved
koladilip
koladilip reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall small minor comments.

cdk/v2/handler.js Outdated Show resolved Hide resolved
versionedRouter.js Show resolved Hide resolved
@saikumarrs saikumarrs merged commit d5086c2 into master Sep 30, 2022
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
@github-actions github-actions bot deleted the feat/onboard-cdk-v2 branch March 15, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@koladilip koladilip koladilip approved these changes

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikumarrs @sanpj2292 @koladilip