Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): marketo - correct attribute to attributes #1446

Merged
merged 1 commit into from
Sep 27, 2022
Merged

feat(integration): marketo - correct attribute to attributes #1446

merged 1 commit into from
Sep 27, 2022

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Sep 27, 2022 •
edited
Loading

Description of the change

Marketo - correct attribute to attribute

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai requested a review from a team as a code owner September 27, 2022 07:07
@yashasvibajpai yashasvibajpai self-assigned this Sep 27, 2022
@yashasvibajpai yashasvibajpai changed the title feat(integration): marketo - correct attribute to attributes, fix tes… feat(integration): marketo - correct attribute to attributes Sep 27, 2022
@yashasvibajpai yashasvibajpai merged commit 80b148f into master Sep 27, 2022
@yashasvibajpai yashasvibajpai deleted the fix/marketo-attributes-typo branch September 27, 2022 08:13
@yashasvibajpai yashasvibajpai restored the fix/marketo-attributes-typo branch September 27, 2022 23:10
yashasvibajpai added a commit that referenced this pull request Sep 27, 2022
@yashasvibajpai
Revert "feat(integration): marketo - correct attribute to attributes,…
c891296 
… fix test cases (#1446)"

This reverts commit 80b148f.
@yashasvibajpai yashasvibajpai mentioned this pull request Sep 27, 2022
Merged
yashasvibajpai added a commit that referenced this pull request Sep 28, 2022
@yashasvibajpai
Revert "feat(integration): marketo - correct attribute to attributes,…
5bcd9d1 
… fix test cases (#1446)" (#1447)

This reverts commit 80b148f.
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
@github-actions github-actions bot deleted the fix/marketo-attributes-typo branch March 15, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashasvibajpai @sanpj2292 @ItsSudip