Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BQStream): add batch support #1377

Merged
merged 19 commits into from
Jan 17, 2023
Merged

feat(BQStream): add batch support #1377

merged 19 commits into from
Jan 17, 2023

Conversation

akashrpo
Copy link
Contributor

Description of the change

add batch support

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akashrpo akashrpo self-assigned this Aug 29, 2022
koladilip
koladilip previously approved these changes Oct 12, 2022
View reviewed changes
utsabc
utsabc previously approved these changes Oct 12, 2022
View reviewed changes
koladilip
koladilip previously approved these changes Oct 14, 2022
View reviewed changes
sanpj2292
sanpj2292 previously approved these changes Oct 14, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@github-actions github-actions bot closed this Nov 15, 2022
@akashrpo akashrpo removed the Stale label Nov 15, 2022
@akashrpo akashrpo reopened this Nov 15, 2022
yashasvibajpai
yashasvibajpai previously approved these changes Jan 9, 2023
View reviewed changes
ItsSudip
ItsSudip previously approved these changes Jan 9, 2023
View reviewed changes
sanpj2292
sanpj2292 previously approved these changes Jan 16, 2023
View reviewed changes
@ItsSudip ItsSudip dismissed stale reviews from sanpj2292, yashasvibajpai, and themself via 27932fe January 16, 2023 12:19
sanpj2292
sanpj2292 previously approved these changes Jan 16, 2023
View reviewed changes
yashasvibajpai
yashasvibajpai previously approved these changes Jan 16, 2023
View reviewed changes
ItsSudip
ItsSudip previously approved these changes Jan 16, 2023
View reviewed changes
@ItsSudip ItsSudip dismissed stale reviews from yashasvibajpai, sanpj2292, and themself via 686ef5b January 16, 2023 15:20
@ItsSudip ItsSudip merged commit 14c7531 into master Jan 17, 2023
@ItsSudip ItsSudip deleted the feature/bqstream branch January 17, 2023 07:25
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@utsabc utsabc utsabc left review comments

@koladilip koladilip koladilip left review comments

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

Assignees

@akashrpo akashrpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akashrpo @sanpj2292 @utsabc @yashasvibajpai @koladilip @ItsSudip