Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: json support for warehouse destinations #1144

Merged
merged 20 commits into from
Jun 3, 2022
Merged

feat: json support for warehouse destinations #1144

merged 20 commits into from
Jun 3, 2022

Conversation

Jayachand
Copy link
Collaborator

@Jayachand Jayachand commented Apr 27, 2022 •
edited
Loading

Description of the change

Json support for warehouse destinations BQ, Postgres, Redshift, Snowflake
Assuming destination json path config to be text column with path values separated by commas ex: testMap.nestedMap, testArray

https://www.notion.so/rudderstacks/Json-support-in-warehouse-destinations-8a9f76ee58e543b693a88528d26c2494#5f715d8d18194d2c97c03109cffa441e

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

saikumarrs
saikumarrs reviewed Apr 29, 2022
View reviewed changes
warehouse/index.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs reviewed Apr 29, 2022
View reviewed changes
warehouse/util.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs previously approved these changes Apr 29, 2022
View reviewed changes
psrikanth88
psrikanth88 requested changes May 6, 2022
View reviewed changes
warehouse/util.js Outdated Show resolved Hide resolved
warehouse/index.js Outdated Show resolved Hide resolved
warehouse/index.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs previously approved these changes May 23, 2022
View reviewed changes
psrikanth88
psrikanth88 previously approved these changes May 26, 2022
View reviewed changes
warehouse/util.js Outdated Show resolved Hide resolved
sivashanmukh
sivashanmukh previously approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@sivashanmukh sivashanmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sivashanmukh
sivashanmukh approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@sivashanmukh sivashanmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

achettyiitr
achettyiitr approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@achettyiitr achettyiitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayachand Jayachand merged commit a431b08 into master Jun 3, 2022
@Jayachand Jayachand deleted the feat.jsonSupport branch August 3, 2022 12:47
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivashanmukh sivashanmukh sivashanmukh approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@psrikanth88 psrikanth88 psrikanth88 left review comments

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

@arnab-p arnab-p Awaiting requested review from arnab-p

@utsabc utsabc Awaiting requested review from utsabc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jayachand @sivashanmukh @psrikanth88 @achettyiitr @saikumarrs