Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Syntax parsing is broken when a # is inside a regex #561

Open
noraj opened this issue Nov 19, 2019 · 2 comments
Open

Syntax parsing is broken when a # is inside a regex #561

noraj opened this issue Nov 19, 2019 · 2 comments
Labels
bug Bug reports

Comments

@noraj
Copy link

noraj commented Nov 19, 2019

Your environment

Version: 1.40.1
Commit: 8795a9889db74563ddd43eb0a897a2384129a619
Date: 2019-11-15T22:58:14.270Z
Electron: 6.1.1
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 4.19.84-1-lts

Expected behavior

(Without the extension.)

image

# should not be considered as the start of a comment when it is inside a regex (same as for string).

Actual behavior

image

Syntax parsing is broken when a # is inside a regex.

@wingrunr21
Copy link
Collaborator

Thanks for the report

@wingrunr21 wingrunr21 added the bug Bug reports label Nov 19, 2019
@wingrunr21
Copy link
Collaborator

This unfortunately is probably not going to be easily resolved. The current grammar is based on the one from Atom which made some changes from the original TextMate grammar to account for some bugs. It appears neither grammar got it quite right.

See atom/language-ruby#82 and textmate/ruby.tmbundle#133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug reports
Projects
None yet
Development

No branches or pull requests

2 participants