Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Refactor muts away, enhance ci builds #155

Merged
merged 4 commits into from
Apr 15, 2020

Conversation

koivunej
Copy link
Collaborator

  • refactor away unnecessary &mut self from ipfs::Ipfs blockstore calls
  • enable building of examples and tests in the same phase
  • require Cargo.lock to be up to date cargo build --locked

This is split and extended from #147, where I'll be dropping the first commit soon-ish.

@koivunej
Copy link
Collaborator Author

oh well, forgot my fixup commit ... I'll let the CI run complete/fail before rebasing.

@koivunej koivunej mentioned this pull request Apr 15, 2020
13 tasks
@koivunej
Copy link
Collaborator Author

Forgot to start by cargo fmt as the master has a few issues at the moment.

@koivunej
Copy link
Collaborator Author

And a transient test failure in the readme-doctest.

@koivunej koivunej requested a review from aphelionz April 15, 2020 12:34
@koivunej
Copy link
Collaborator Author

If this is ok, I think we should rebase and merge or just merge.

@aphelionz aphelionz merged commit a89ce4b into rs-ipfs:master Apr 15, 2020
@koivunej koivunej deleted the refactor_muts_away branch April 15, 2020 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants