Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5975742 breaks support for some Dovecot forwarding parameters #7860

Closed
johndoh opened this issue Jan 27, 2021 · 2 comments
Closed

5975742 breaks support for some Dovecot forwarding parameters #7860

johndoh opened this issue Jan 27, 2021 · 2 comments

Comments

@johndoh
Copy link
Contributor

johndoh commented Jan 27, 2021

Dovecot supports a selection of parameters for connection forwarding. The parameters are passed as part of the ID commend. Examples of it in use are in this plugin and also some discussion in #5336.

I understand that 5975742 was done as sending the ID command before auth caused problems in one use case but it is useful in another use case. Could the change be amended to allow plugins to send the ID command before authentication when required?

@alecpl
Copy link
Member

alecpl commented Jan 28, 2021

Right. Let's create an extra argument to the storage_connect hook, e.g. 'preauth_ident'. I'm not sure it should be boolean flag that will move the existing ID command earlier, or maybe a set of separate ID parameters to use for an additional ID command call.

@alecpl
Copy link
Member

alecpl commented Jan 30, 2021

Fix merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants