Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete nfs config for stale subvolume #302

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

yati1998
Copy link
Contributor

this commit deletes the nfs config entry for
the stale subvolume

Resolves: #272

@yati1998 yati1998 marked this pull request as ready for review June 20, 2024 06:08
@yati1998 yati1998 requested a review from Madhu-1 June 20, 2024 06:08
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
@Madhu-1 Madhu-1 requested review from subhamkrai and removed request for nixpanic June 24, 2024 11:40
Copy link
Collaborator

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

pkg/filesystem/subvolume.go Outdated Show resolved Hide resolved
this commit deletes the nfs config entry for
the stale subvolume

Signed-off-by: yati1998 <ypadia@redhat.com>
@subhamkrai subhamkrai merged commit 9c6a69e into rook:master Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending cephfs stale cleanup
4 participants