-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@rollup/plugin-typescript] { compilerOptions: { module: "nodeNext" } } overwritten when coming from "extends" in tsconfig.json #1583
Comments
I'm facing the same issue...
This workaround works, but we loose all the purpose of extending a config... |
Explicitly adding it to the plugin declaration also works. Not ideal, but IMO it's better than having to change tsconfig.json. plugins: [typescript({ module: 'nodeNext' })] |
you can also dynamically add it to to the plugin declaration using something like this in a
Presumably some version of the |
Expected Behavior
I have two typescript config files: tsconfig.base.json and tsconfig.json.
In the tsconfig.base.json I have
{ compilerOptions: { module: "nodeNext" } }
.tsconfig.json extends tsconfig.base.json.
When I run the typescript config, I expect that it takes the
module: "nodeNext"
into account that I configured in the tsconfig.base.ts.Actual Behavior
The plugin overwrites
{ compilerOptions: { module: "nodeNext" } }
with{ compilerOptions: { module: "esNext" } }
. This produces the following error with TypeScript 5.2 and up (see also microsoft/TypeScript#54567):Additional Information
Cause of the bug
https://github.com/rollup/plugins/blob/typescript-v11.1.3/packages/typescript/src/options/tsconfig.ts#L155-L196
This block gets the JSON parsed tsConfigFile that's used to process the project (in the reproduction, thats
./tsconfig.json
), adds the default options to thecompilerOptions
, and passes it on to TypeScript to completely parse the file, fill in defaults, etc.However, if the tsconfig.json contains an extends which defines the module, the tsconfig.json ends up like this:
These compilerOptions take precedence over the one in the tsconfig.base.json, effectively overriding the project's module setting.
Workaround
Move / copy
{ compilerOptions: { module: "nodeNext" } }
to the tsconfig.json file.This way,
...tsConfigFile.compilerOptions
overwrites the property from...DEFAULT_COMPILER_OPTIONS
. However, it does lead to repetition that theextends
should solve.The text was updated successfully, but these errors were encountered: